Spamming Shift + Block + Attack during the landfall - will result in a weird combination of arts played out

[Aluerie]

Basically video:

landing_bug.mp4

I didn't record my key presses, but I just mash Shift + Left Click (Attack) while landing. My settings also bind keyboard Block to shift. Also sometimes it will play out Ichimonji, sometimes Cross.

In casual gaming experience this bug shouldnt be a bother since a normal person shouldn't spam holding/unholding Shift, however annoying bug nevertheless.

---

It happens because we force unequipping combat art when blocking to feel more fluid (by default non-forcing version doesn't do that). However this animation also affects jumping, looks like.

Sekiro-ShiftCombatArt/ShiftArt/Functions/Functions.cpp

Lines 394 to 397 in 0974ee5

	int animation4 = *(int *)(actionRequestModule + 0x1B4); // idk?
	int force = ((realID != 5000) || (animation4 == 1));
	bool success = EquipItem(COMBAT_ART_SLOT, (__int64)&icon, force);
	return success;

The usual notion: Please help. I'm noob in cpp.

[Aluerie]

Comment: Same issue happens in Aluerie/SekiroHotkeySystem#1

[Aluerie]

After a bit of code tankling I think this bug is heavily reduced in its frequency.

back-slash.mp4

There is also Ichi variation

[Aluerie]

After todays commit - I can't find a situation where the animation bug occurs.

The code is not pretty though.