Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: several peerDeps are flagged as optional in @o3r/eslint-plugin but usage of it are exposed at the root #2482

Open
matthieu-crouzet opened this issue Nov 18, 2024 · 2 comments · May be fixed by #2354
Labels

Comments

@matthieu-crouzet
Copy link
Contributor

Package name

eslint-plugin

Package version

11.4.1

Reproduction steps

Use @o3r/eslint-plugin without having yaml-eslint-parser installed.

Current result

Issue while running linter because yaml-eslint-parser is not installed.

Expected result

To not introduce breaking changes, in v11 we can remove the optional flags.
For v12 we can expose sub-entries like @o3r/eslint-plugin/yaml

Additional comments

Same issue for jsonc-eslint-parser and @angular-eslint/template-parser

@matthieu-crouzet
Copy link
Contributor Author

Issue referenced in packages/@o3r/eslint-config/schematics/ng-add/index.ts

@kpanot
Copy link
Contributor

kpanot commented Nov 21, 2024

Hi,

Can you precise the issue on jsonc-eslint-parser and @angular-eslint/template-parser?
Looking at the code:

Regarding yaml-eslint-parser, it is properly turned optional in #2354 (see code diff: https://github.com/AmadeusITGroup/otter/pull/2354/files#diff-5faa91646fd6988a6a6817d4291e4a7fba68663d540cf9afa89fc12b9947c4e7)

@kpanot kpanot linked a pull request Nov 21, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants