From c77ab04c55c024a339f69503e26922f608f772e1 Mon Sep 17 00:00:00 2001 From: UebelAndre Date: Wed, 11 Dec 2024 01:21:08 -0800 Subject: [PATCH] Fix BCR presubmit pipeline (#3082) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hopefully this resolves the following: https://buildkite.com/bazel/bcr-presubmit/builds/9302#0193b38a-65b5-4be1-91b6-138d4ab9cc90 ``` ERROR: The test module directory does not exist in the source archive: /Users/buildkite/builds/bk-macos-arm64-0n05/bazel-org-repo-root/output/extensions/bindgen/extensions/bindgen Traceback (most recent call last): File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 537, in sys.exit(main()) ^^^^^^ File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 528, in main repo_location, config_file = prepare_test_module_repo(args.module_name, args.module_version, args.overwrite_bazel_version) ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 269, in prepare_test_module_repo error("The test module directory does not exist in the source archive: %s" % test_module_root) File "/Users/buildkite/builds/bk-macos-arm64-0n05/bazel/bcr-presubmit/bcr_presubmit.py", line 58, in error raise BcrPipelineException("BCR Presubmit failed!") BcrPipelineException: BCR Presubmit failed! 🚨 Error: The command exited with status 1 ^^^ +++ ``` My assumption is that `module_path` is an extension of where the presubmit yaml exists relative to the root one. So this should finally enable CI to run in th eright place with the correct dependency. --- .bcr/extensions/bindgen/presubmit.yml | 2 +- .bcr/extensions/prost/presubmit.yml | 2 +- .bcr/extensions/protobuf/presubmit.yml | 2 +- .bcr/extensions/wasm_bindgen/presubmit.yml | 2 +- MODULE.bazel | 2 +- extensions/bindgen/MODULE.bazel | 4 ++-- extensions/prost/MODULE.bazel | 4 ++-- extensions/protobuf/MODULE.bazel | 4 ++-- extensions/wasm_bindgen/MODULE.bazel | 4 ++-- version.bzl | 2 +- 10 files changed, 14 insertions(+), 14 deletions(-) diff --git a/.bcr/extensions/bindgen/presubmit.yml b/.bcr/extensions/bindgen/presubmit.yml index 3c7cd615dd..371a226a65 100644 --- a/.bcr/extensions/bindgen/presubmit.yml +++ b/.bcr/extensions/bindgen/presubmit.yml @@ -1,5 +1,5 @@ bcr_test_module: - module_path: "extensions/bindgen" + module_path: "" matrix: platform: ["macos_arm64", "ubuntu2004", "windows"] bazel: ["7.x"] diff --git a/.bcr/extensions/prost/presubmit.yml b/.bcr/extensions/prost/presubmit.yml index d77338a95c..371a226a65 100644 --- a/.bcr/extensions/prost/presubmit.yml +++ b/.bcr/extensions/prost/presubmit.yml @@ -1,5 +1,5 @@ bcr_test_module: - module_path: "extensions/prost" + module_path: "" matrix: platform: ["macos_arm64", "ubuntu2004", "windows"] bazel: ["7.x"] diff --git a/.bcr/extensions/protobuf/presubmit.yml b/.bcr/extensions/protobuf/presubmit.yml index 77025299a2..371a226a65 100644 --- a/.bcr/extensions/protobuf/presubmit.yml +++ b/.bcr/extensions/protobuf/presubmit.yml @@ -1,5 +1,5 @@ bcr_test_module: - module_path: "extensions/protobuf" + module_path: "" matrix: platform: ["macos_arm64", "ubuntu2004", "windows"] bazel: ["7.x"] diff --git a/.bcr/extensions/wasm_bindgen/presubmit.yml b/.bcr/extensions/wasm_bindgen/presubmit.yml index 57eeffc99f..371a226a65 100644 --- a/.bcr/extensions/wasm_bindgen/presubmit.yml +++ b/.bcr/extensions/wasm_bindgen/presubmit.yml @@ -1,5 +1,5 @@ bcr_test_module: - module_path: "extensions/wasm_bindgen" + module_path: "" matrix: platform: ["macos_arm64", "ubuntu2004", "windows"] bazel: ["7.x"] diff --git a/MODULE.bazel b/MODULE.bazel index 0a9d47d3c8..d01f4026af 100644 --- a/MODULE.bazel +++ b/MODULE.bazel @@ -2,7 +2,7 @@ module( name = "rules_rust", - version = "0.55.4", + version = "0.55.5", ) ############################################################################### diff --git a/extensions/bindgen/MODULE.bazel b/extensions/bindgen/MODULE.bazel index 5663328ffb..d5d67e9675 100644 --- a/extensions/bindgen/MODULE.bazel +++ b/extensions/bindgen/MODULE.bazel @@ -2,12 +2,12 @@ module( name = "rules_rust_bindgen", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "rules_rust", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "bazel_skylib", diff --git a/extensions/prost/MODULE.bazel b/extensions/prost/MODULE.bazel index 9599a4fc86..4093ca8189 100644 --- a/extensions/prost/MODULE.bazel +++ b/extensions/prost/MODULE.bazel @@ -2,12 +2,12 @@ module( name = "rules_rust_prost", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "rules_rust", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "platforms", diff --git a/extensions/protobuf/MODULE.bazel b/extensions/protobuf/MODULE.bazel index c0cb1efcae..0975647c91 100644 --- a/extensions/protobuf/MODULE.bazel +++ b/extensions/protobuf/MODULE.bazel @@ -2,12 +2,12 @@ module( name = "rules_rust_protobuf", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "rules_rust", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "bazel_skylib", diff --git a/extensions/wasm_bindgen/MODULE.bazel b/extensions/wasm_bindgen/MODULE.bazel index 9727c916bd..f6d7e80611 100644 --- a/extensions/wasm_bindgen/MODULE.bazel +++ b/extensions/wasm_bindgen/MODULE.bazel @@ -2,12 +2,12 @@ module( name = "rules_rust_wasm_bindgen", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "rules_rust", - version = "0.55.4", + version = "0.55.5", ) bazel_dep( name = "bazel_skylib", diff --git a/version.bzl b/version.bzl index a3e26a5766..c7501ad7ec 100644 --- a/version.bzl +++ b/version.bzl @@ -1,3 +1,3 @@ """The version of rules_rust.""" -VERSION = "0.55.4" +VERSION = "0.55.5"