Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add system tray support #20

Closed
AminBhst opened this issue Nov 12, 2023 · 14 comments
Closed

Add system tray support #20

AminBhst opened this issue Nov 12, 2023 · 14 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@AminBhst
Copy link
Owner

Package needed: system_tray or tray_manager

  • It is important to check whether or not a minimized to tray window can be brought to front upon receiving download requests from the browser extension. If that is not possible, multiple window support could solve this problem. In the meantime, as a workaround we can send a system notification when a download request has been captured from the browser
  • Ask the user whether or not the app should be moved to tray when the close button is clicked. A 'remember this decision' option also has to be added which requires a new app setting entry.
@AminBhst AminBhst added enhancement New feature or request good first issue Good for newcomers labels Nov 12, 2023
@ZorinFoss
Copy link
Contributor

Hi @AminBhst

you can check this project to implement system tray support

@AminBhst
Copy link
Owner Author

@ZorinFoss Sure. The problem isn't that I faced issues trying to implement it, it's that I just haven't had enough time to work on it. It will most likely be included for the next release.

@ZorinFoss
Copy link
Contributor

i hope so, system tray is very important part.

@AminBhst
Copy link
Owner Author

For sure. It's my priority right now. Hopefully it will be done by next week.

@AminBhst
Copy link
Owner Author

AminBhst commented Feb 5, 2024

Now available in V1.4.3

@AminBhst AminBhst closed this as completed Feb 5, 2024
@ZorinFoss
Copy link
Contributor

@AminBhst Well done!

@ZorinFoss
Copy link
Contributor

the browser extension does not work after the last update

@AminBhst
Copy link
Owner Author

AminBhst commented Feb 5, 2024

the browser extension does not work after the last update

You sure? I just checked and it worked fine. I didn't really change much about the browser extension behavior with this update.

@AminBhst
Copy link
Owner Author

AminBhst commented Feb 5, 2024

@ZorinFoss Also would please tell me what the exact package name for appindicator3-0.1 is on Arch? I want to add it to the README but I don't own an Arch OS to test it myself.

@ZorinFoss
Copy link
Contributor

it's libappindicator-gtk3

@ZorinFoss
Copy link
Contributor

the browser extension does not work after the last update

You sure? I just checked and it worked fine. I didn't really change much about the browser extension behavior with this update.

i test on brave and on chromium and it does not work.

@AminBhst
Copy link
Owner Author

AminBhst commented Feb 5, 2024

the browser extension does not work after the last update

You sure? I just checked and it worked fine. I didn't really change much about the browser extension behavior with this update.

i test on brave and on chromium and it does not work.

Could you also test it on Firefox as well and let me know if it works? Also try it with different links.

@ZorinFoss
Copy link
Contributor

firefox works, but chromium browsers not.

@AminBhst
Copy link
Owner Author

AminBhst commented Feb 5, 2024

firefox works, but chromium browsers not.

Then it is unrelated to this update. Would you mind opening an issue in the browser-extension repo and also including a sample download link? I'll check it out.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants