Skip to content

Commit

Permalink
Merge pull request #224 from AmpersandTarski/issue/180-warning-undefi…
Browse files Browse the repository at this point in the history
…ned-array-key

Bugfix Php warning about undefined array key 'ifcPath'
  • Loading branch information
Michiel-s authored Dec 29, 2024
2 parents f071f56 + f926af9 commit a96d9b7
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
6 changes: 3 additions & 3 deletions backend/src/Ampersand/Controller/ResourceController.php
Original file line number Diff line number Diff line change
Expand Up @@ -61,7 +61,7 @@ public function createNewResourceId(Request $request, Response $response, array
public function getResource(Request $request, Response $response, array $args): Response
{
// Input
$pathList = ResourcePath::makePathList($args['resourcePath']);
$pathList = ResourcePath::makePathList($args['resourcePath'] ?? null);
$options = Options::getFromRequestParams($request->getQueryParams());
$depth = $request->getQueryParam('depth');

Expand All @@ -79,7 +79,7 @@ public function getResource(Request $request, Response $response, array $args):
public function putPatchPostResource(Request $request, Response $response, array $args): Response
{
// Input
$pathList = ResourcePath::makePathList($args['ifcPath']);
$pathList = ResourcePath::makePathList($args['ifcPath'] ?? null);
$options = Options::getFromRequestParams($request->getQueryParams());
$depth = $request->getQueryParam('depth');
$body = $request->reparseBody()->getParsedBody();
Expand Down Expand Up @@ -141,7 +141,7 @@ public function putPatchPostResource(Request $request, Response $response, array
public function deleteResource(Request $request, Response $response, array $args): Response
{
// Input
$pathList = ResourcePath::makePathList($args['ifcPath']);
$pathList = ResourcePath::makePathList($args['ifcPath'] ?? null);

// Prepare
$transaction = $this->app->newTransaction();
Expand Down
1 change: 1 addition & 0 deletions changelog.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Additional labels for pre-release and build metadata are available as extensions
* It affects names and labels of all artefacts (concepts, relations, interfaces, rules, views, etc)
* It affects metadata from PrototypeContext. Be sure to update those when used in application extensions or running environments
* [Issue 161](https://github.com/AmpersandTarski/prototype/issues/161) Bugfix ConceptNotDefinedException
* [Issue 180](https://github.com/AmpersandTarski/prototype/issues/180) Bugfix Php warning about undefined array key 'ifcPath'
* [Issue 210](https://github.com/AmpersandTarski/prototype/issues/210) Bugfix using TableType enum for method to empty a relation population
* [Issue 218](https://github.com/AmpersandTarski/prototype/issues/218) Improve error reporting for exceptions in excel importer
* [Issue 221](https://github.com/AmpersandTarski/prototype/issues/221) Bugfix typescript type object property naming by surrounding view labels with quotes
Expand Down

0 comments on commit a96d9b7

Please sign in to comment.