feat!: Change naming approach of all typography tokens #1845
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # proprietary/tokens/src/components/ams/accordion.tokens.json # proprietary/tokens/src/components/ams/avatar.tokens.json # proprietary/tokens/src/components/ams/badge.tokens.json # proprietary/tokens/src/components/ams/blockquote.tokens.json # proprietary/tokens/src/components/ams/character-count.tokens.json # proprietary/tokens/src/components/ams/checkbox.tokens.json # proprietary/tokens/src/components/ams/date-input.tokens.json # proprietary/tokens/src/components/ams/description-list.tokens.json # proprietary/tokens/src/components/ams/error-message.tokens.json # proprietary/tokens/src/components/ams/field-set.tokens.json # proprietary/tokens/src/components/ams/heading.tokens.json # proprietary/tokens/src/components/ams/label.tokens.json # proprietary/tokens/src/components/ams/ordered-list.tokens.json # proprietary/tokens/src/components/ams/page-heading.tokens.json # proprietary/tokens/src/components/ams/pagination.tokens.json # proprietary/tokens/src/components/ams/paragraph.tokens.json # proprietary/tokens/src/components/ams/password-input.tokens.json # proprietary/tokens/src/components/ams/radio.tokens.json # proprietary/tokens/src/components/ams/search-field.tokens.json # proprietary/tokens/src/components/ams/select.tokens.json # proprietary/tokens/src/components/ams/skip-link.tokens.json # proprietary/tokens/src/components/ams/switch.tokens.json # proprietary/tokens/src/components/ams/table.tokens.json # proprietary/tokens/src/components/ams/text-area.tokens.json # proprietary/tokens/src/components/ams/text-input.tokens.json # proprietary/tokens/src/components/ams/time-input.tokens.json # proprietary/tokens/src/components/ams/top-task-link.tokens.json # proprietary/tokens/src/components/ams/unordered-list.tokens.json
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
VincentSmedinga
commented
Feb 10, 2025
# Conflicts: # proprietary/tokens/src/components/ams/accordion.tokens.json # proprietary/tokens/src/components/ams/blockquote.tokens.json # proprietary/tokens/src/components/ams/description-list.tokens.json # proprietary/tokens/src/components/ams/figure.tokens.json # proprietary/tokens/src/components/ams/heading.tokens.json # proprietary/tokens/src/components/ams/ordered-list.tokens.json # proprietary/tokens/src/components/ams/page-heading.tokens.json # proprietary/tokens/src/components/ams/paragraph.tokens.json # proprietary/tokens/src/components/ams/unordered-list.tokens.json
# Conflicts: # proprietary/tokens/src/components/ams/accordion.tokens.json # proprietary/tokens/src/components/ams/button.tokens.json # proprietary/tokens/src/components/ams/checkbox.tokens.json # proprietary/tokens/src/components/ams/file-input.tokens.json # proprietary/tokens/src/components/ams/radio.tokens.json # proprietary/tokens/src/components/ams/search-field.tokens.json # proprietary/tokens/src/components/ams/switch.tokens.json # proprietary/tokens/src/components/ams/tabs.tokens.json
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
# Conflicts: # proprietary/tokens/src/components/ams/link-list.tokens.json # proprietary/tokens/src/components/ams/link.tokens.json # proprietary/tokens/src/components/ams/page-menu.tokens.json # proprietary/tokens/src/components/ams/top-task-link.tokens.json
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
VincentSmedinga
commented
Feb 18, 2025
Comment on lines
8
to
9
| "font-size": { "value": "{ams.typography.body-text.xl.font-size}" }, | ||
| "line-height": { "value": "{ams.typography.body-text.xl.line-height}" } |
There was a problem hiding this comment.
We agreed on body-text-small, body-text-large, heading-3, heading-4, heading-5 and heading-6. We don’t see icons being combined with Headings 1 and 2 or extra large body text like Blockquote.
It’s become a hefty refactoring of the Icon and Icon Button components and the prop values aren’t the prettiest, but I think this is what needs to be expressed.
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
VincentSmedinga
changed the title
VincentSmedinga
changed the title
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
github-actions
bot
temporarily deployed
to
demo-DES-1073-refactor-text-level-scale
|
I’m replacing this PR with a fresh one. |
VincentSmedinga
deleted the
feature/DES-1073-refactor-text-level-scale
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
Thank you for contributing to the project!
Please use this template to help us handle your PR smoothly.
What
Refactors typography tokens:
ams.texttoams.typographyto match NLDSbody-textandheadinggroups to prepare for separate line height valuessizeprop of Icon and Icon Button to reflect that they may be paired with either a heading or body text component, whose line heights may differ even if their font sizes are the samefont-weighttoken to Buttonfont-familytoken from SwitchWhy
To implement a stable API of brand tokens for typography.
How
Meticulously.
Checklist
Before submitting your pull request, please ensure you have done the following. Check each checkmark if you have done so or if it wasn't necessary:
Additional notes