From 623f066cd621eb53f8a4b516dff8f0de08f7136c Mon Sep 17 00:00:00 2001 From: Tim van Oostrom Date: Thu, 21 Sep 2023 14:51:50 +0200 Subject: [PATCH] Add test --- app/test_zorgned_service.py | 25 +++++++++++++++++++------ app/zorgned_service.py | 8 +++++--- 2 files changed, 24 insertions(+), 9 deletions(-) diff --git a/app/test_zorgned_service.py b/app/test_zorgned_service.py index 08329b7..a342995 100644 --- a/app/test_zorgned_service.py +++ b/app/test_zorgned_service.py @@ -9,11 +9,11 @@ class ZorgnedApiMock: status_code = 200 response_json = None - content = { - "mock": "Data" - } + content = {"mock": "Data"} + + def __init__(self, response_json=None, status_code=200): + self.status_code = status_code - def __init__(self, response_json=None): if isinstance(response_json, str): with open(response_json, "r") as read_file: self.response_json = json.load(read_file) @@ -29,7 +29,6 @@ def raise_for_status(self): class ZorgnedServiceTest(TestCase): - @patch("app.zorgned_service.requests.get") def test_get_clientnummer_response(self, get_mock): get_mock.return_value = ZorgnedApiMock(BASE_PATH + "/fixtures/persoon.json") @@ -38,5 +37,19 @@ def test_get_clientnummer_response(self, get_mock): self.assertEqual(clientnummer, 304184) + @patch("app.zorgned_service.requests.get") + def test_get_clientnummer_not_found_response(self, get_mock): + get_mock.return_value = ZorgnedApiMock(status_code=404) + + clientnummer = get_clientnummer(123) + + self.assertEqual(clientnummer, None) + + @patch("app.zorgned_service.requests.get") + def test_get_clientnummer_bad_request_response(self, get_mock): + get_mock.return_value = ZorgnedApiMock(status_code=400) + + self.assertRaises(Exception, get_clientnummer, 123) + def test_volledig_clientnummer(self): - self.assertEquals(volledig_clientnummer(304184), "03630000304184") + self.assertEqual(volledig_clientnummer(304184), "03630000304184") diff --git a/app/zorgned_service.py b/app/zorgned_service.py index 9aeeb48..3b67b4e 100644 --- a/app/zorgned_service.py +++ b/app/zorgned_service.py @@ -27,17 +27,19 @@ def send_api_request(bsn, operation="", query_params=None): params=query_params, ) - res.raise_for_status() - return res def send_api_request_json(bsn, operation="", query_params=None): res = send_api_request(bsn, operation, query_params) - if len(res.content) < 1: + # 404 means bsn is now known to ZorgNed + if len(res.content) < 1 or res.status_code == 404: return None + # Other error codes should be propagated + res.raise_for_status() + response_data = res.json() logging.debug(json.dumps(response_data, indent=4))