Fix potential deadlock and wait until service is available #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrej Orsula <[email protected]>
AndrejOrsula
approved these changes
Mar 4, 2025
AndrejOrsula
changed the title
andrewbowman23
added a commit
to andrewbowman23/pymoveit2
that referenced
this pull request
Mar 4, 2025
andrewbowman23
added a commit
to andrewbowman23/pymoveit2
that referenced
this pull request
Mar 4, 2025
andrewbowman23
added a commit
to andrewbowman23/pymoveit2
that referenced
this pull request
Mar 4, 2025
Can't use rclpy.spin unless rclpy is imported. Also, wait_until_exectued use of spin was incorrect.
andrewbowman23
added a commit
to andrewbowman23/pymoveit2
that referenced
this pull request
Mar 4, 2025
Can't use rclpy.spin unless rclpy is imported. Also, wait_until_executed use of spin was incorrect.
AndrejOrsula
added a commit
that referenced
this pull request
Mar 4, 2025
* Fix rclpy import and spin issues from (#87) Can't use rclpy.spin unless rclpy is imported. Also, wait_until_executed use of spin was incorrect. * Apply pre-commit suggestions Signed-off-by: Andrej Orsula <[email protected]> --------- Signed-off-by: Andrej Orsula <[email protected]> Co-authored-by: Andrej Orsula <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rate.sleep()withrclpy.spin_once(self._node, timeout_sec=1.0)to avoid sleeping forever.