-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Option to choose only one crop mode. #3
Comments
Hello @gaurava-mishra, If I understand you correctly, 512px is the upper limit and it's ok if an image is smaller than 512px. I just added the ability to restrict the possible aspect ratio:
Please update the dependency version to 1.0.3 and try it. |
Thanks Alot.
I will check it out.
…On Tue, 22 Aug, 2023, 10:53 pm Andrei R., ***@***.***> wrote:
Hello,
If I understand you correctly, 512px is the upper limit and it's ok if an
image is smaller than 512px. I just added the ability to restrict the
possible aspect ratio: strictAspectRatio in ImageTransformation. So if my
guess is correct, you will be able to restrict the request like this:
PickRequest(
source = ...,
transformation = ImageTransformation(
maxSidePx = 512,
strictAspectRatio = AspectRatioIPP("1:1", 1f, 1f),
),
)
Please update the dependency version to 1.0.3 and try it.
—
Reply to this email directly, view it on GitHub
<#3 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ADZ46FFYGHIWG6DS3XAMW23XWTTHTANCNFSM6AAAAAA3X6KB5M>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
I have checked it and it is working fine. One more this we could notice, Could you please add minSidePx in this library? |
Let me break your question into possible stages:
So basically at this point I don't see the reliable solution. As far as I know we cannot prevent user from picking small images from the system. I may be wrong. |
Hello,
This is not an issue, but a possibile feature that could be widely used.
I am working an application that need final image to be scaled in 512x512 ( i.e. square with custome pixel value).
I could able to use this library though, but app will crash if user select some other crop option rather than square like 16:9, 4:3 5:4 etc.
I have working experience with uCrop earlier, and I knew that uCrop provides options to retrict the user to crop in any particular ratio.
I think, you guys doing good job to combine picker and cropper in a single frame.
Could you also consider this feature request?
The text was updated successfully, but these errors were encountered: