aml: move enable_acpi to aml_subsys

Signed-off-by: Andy-Python-Programmer <[email protected]>

Author: Andy-Python-Programmer

src/aero_kernel/src/acpi/aml.rs

@@ -10,6 +10,13 @@ pub enum SleepState {
 
 pub trait AmlSubsystem: Send + Sync {
     fn enter_state(&self, state: SleepState);
+    /// Ensures that the system control interrupt (SCI) is properly
+    /// configured, disables SCI event sources, installs the SCI handler, and
+    /// transfers the system hardware into ACPI mode.
+    ///
+    /// ## Parameters
+    /// * `mode` - IRQ mode (ACPI spec section 5.8.1)
+    fn enable_acpi(&self, mode: u32);
 }
 
 static AML_SUBSYSTEM: Once<Arc<dyn AmlSubsystem>> = Once::new();

src/aero_kernel/src/arch/x86_64/interrupts/mod.rs

@@ -67,6 +67,10 @@ impl InterruptController {
         }
     }
 
+    pub fn method(&self) -> usize {
+        self.method.load(Ordering::SeqCst)
+    }
+
     /// Send EOI, indicating the completion of an interrupt.
     pub fn eoi(&self) {
         match self.method.load(Ordering::Acquire) {

src/aero_kernel/src/arch/x86_64/mod.rs

@@ -26,6 +26,7 @@ pub mod task;
 pub mod tls;
 
 use crate::acpi;
+use crate::acpi::aml;
 use crate::apic;
 use crate::cmdline;
 use crate::mem;
@@ -42,6 +43,8 @@ use crate::utils::io;
 use raw_cpuid::CpuId;
 use stivale_boot::v2::*;
 
+use self::interrupts::INTERRUPT_CONTROLLER;
+
 #[repr(C, align(4096))]
 struct P2Align12<T>(T);
 
@@ -234,6 +237,10 @@ extern "C" fn x86_64_aero_ap_main(ap_id: usize, stack_top_addr: VirtAddr) {
     crate::aero_ap_main(ap_id);
 }
 
+pub fn enable_acpi() {
+    aml::get_subsystem().enable_acpi(INTERRUPT_CONTROLLER.method() as _);
+}
+
 pub fn init_cpu() {
     unsafe {
         // Enable the no-execute page protection feature.

src/aero_kernel/src/drivers/lai.rs

@@ -42,32 +42,26 @@ impl lai::Host for LaiHost {
     }
 
     // Port I/O functions:
-    #[inline]
     fn outb(&self, port: u16, value: u8) {
         unsafe { io::outb(port, value) }
     }
 
-    #[inline]
     fn outw(&self, port: u16, value: u16) {
         unsafe { io::outw(port, value) }
     }
 
-    #[inline]
     fn outd(&self, port: u16, value: u32) {
         unsafe { io::outl(port, value) }
     }
 
-    #[inline]
     fn inb(&self, port: u16) -> u8 {
         unsafe { io::inb(port) }
     }
 
-    #[inline]
     fn inw(&self, port: u16) -> u16 {
         unsafe { io::inw(port) }
     }
 
-    #[inline]
     fn ind(&self, port: u16) -> u32 {
         unsafe { io::inl(port) }
     }
@@ -91,7 +85,6 @@ impl lai::Host for LaiHost {
     }
 
     // Memory functions:
-    #[inline]
     fn map(&self, address: usize, _count: usize) -> *mut u8 {
         PhysAddr::new(address as u64)
             .as_hhdm_virt()
@@ -105,6 +98,10 @@ impl aml::AmlSubsystem for LaiSubsystem {
     fn enter_state(&self, state: aml::SleepState) {
         lai::enter_sleep(state as u8)
     }
+
+    fn enable_acpi(&self, mode: u32) {
+        lai::enable_acpi(mode);
+    }
 }
 
 pub fn init_lai() {
@@ -114,8 +111,6 @@ pub fn init_lai() {
     lai::set_acpi_revision(get_acpi_table().revision() as _);
     lai::create_namespace();
 
-    lai::enable_acpi(1);
-
     let subsystem = Arc::new(LaiSubsystem);
     aml::init(subsystem);
 }

src/aero_kernel/src/main.rs

@@ -144,6 +144,8 @@ fn kernel_main_thread() {
     modules::init();
     log::info!("loaded kernel modules");
 
+    arch::enable_acpi();
+
     drivers::pci::init(&mut offset_table);
     log::info!("loaded PCI driver");