Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(api): add method
read_study_api
#22feat(api): add method
read_study_api
#22Changes from 39 commits
bcdf961
d31bba1
e3c5030
e06f118
d581ddb
2ab7da7
6906b17
603cfe7
ab74da8
5b8d269
877f53a
838ae57
bb9c9e4
2dd6b7a
483e4d6
d2f4fd9
6ef393c
ed5aa63
4fcd430
0e16576
8238314
41821a5
e402e5b
671336f
b56994a
d0b8052
af39424
0fd3de8
e21278d
2bdb548
a7e28fe
91d01da
4c2d927
a729713
c4767cf
7d35ba7
e605d28
4b4edd4
f6f1a61
e140264
95b08fc
78c93c1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To simplify your test you can just replace the json you introduce by:
and your test will still pass.
You can even remove these variables and simply pur the [] or {} inside the .get() to make it even simpler
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's better. You can introduce
actual_area_fr = actual_study.get_areas()["fr"]
andexpected_area_fr = study.get_areas()["fr"]
to avoid calling get_areas multiple times.Also I would prefer you do the same check as the ones for areas (line 228) for thermal, storages and renewables as it would check more things.
Last thing, I believe you can also check the settings