Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ADD submission pipeline log capture #402

Closed
wabscale opened this issue Sep 21, 2022 · 0 comments
Closed

ADD submission pipeline log capture #402

wabscale opened this issue Sep 21, 2022 · 0 comments
Assignees
Labels
backend feature New feature or request k8s

Comments

@wabscale
Copy link
Collaborator

We'll want to start off with adding a new pipeline_log blob column to the submission table

class Submission(db.Model):

Create the migration for it (running it will be tricky as it will definitely take a minute to run)

Then replace this with something that will get the logs and store them on some new column of the submission:

elif job.status.succeeded is not None and job.status.succeeded >= 1:
# Attempt to delete the k8s job
delete_pipeline_job(batch_v1, job)

I'm not sure we really need to be explicitly deleting jobs as they finish. We can just rely on kubernetes cleaning them up, or we can add the job ttl https://kubernetes.io/docs/concepts/workloads/controllers/ttlafterfinished/

@wabscale wabscale added feature New feature or request backend labels Sep 21, 2022
@wabscale wabscale self-assigned this Sep 21, 2022
@wabscale wabscale moved this to Todo in AnubisLMS Sep 21, 2022
@wabscale wabscale added the k8s label Sep 21, 2022
Repository owner moved this from Todo to Done in AnubisLMS Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature New feature or request k8s
Projects
Status: Done
Development

No branches or pull requests

1 participant