-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RTG Buffs via ItemDurationMultiplier #9664
Draft
SomeonesShade
wants to merge
7
commits into
Anuken:master
Choose a base branch
from
SomeonesShade:ConsumeGenerator-ItemDurationMultipliers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
RTG Buffs via ItemDurationMultiplier #9664
SomeonesShade
wants to merge
7
commits into
Anuken:master
from
SomeonesShade:ConsumeGenerator-ItemDurationMultipliers
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Duration issues when there is no items left, duration is set to 1, affecting while it's still "valid".
killer check for null |
nice, should be fixed |
this pr would be repurposed for just rtg buffs directly, I'll probably drop the hjson support since I'm not qualified for it (unless it already does work) |
SomeonesShade
changed the title
Added itemDurationMultipliers to ConsumeGenerator
RTG Buffs via ItemDurationMultiplier
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RTG Phase is now buffable under the code changes.
[TODO: Do the changes, add picture]
(Blast Steam... yeah I tried but there is no way to make it work lol in concept. Massive water consumption is tackled with spore, pyra has high power/refined/coal effecient, and coal. is the raw ore into power conversion. Blast has no place.)
If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:
TODO: