Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTG Buffs via ItemDurationMultiplier #9664

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

SomeonesShade
Copy link
Contributor

@SomeonesShade SomeonesShade commented Mar 21, 2024

RTG Phase is now buffable under the code changes.

[TODO: Do the changes, add picture]

(Blast Steam... yeah I tried but there is no way to make it work lol in concept. Massive water consumption is tackled with spore, pyra has high power/refined/coal effecient, and coal. is the raw ore into power conversion. Blast has no place.)

If your pull request is not translation or serverlist-related, read the list of requirements below and check each box:

  • I have read the contribution guidelines.
  • I have ensured that my code compiles, if applicable.
  • I have ensured that any new features in this PR function correctly in-game, if applicable.

TODO:

  • UI?

Duration issues when there is no items left, duration is set to 1, affecting while it's still "valid".
@camelStyleUser
Copy link
Contributor

killer check for null

@SomeonesShade
Copy link
Contributor Author

SomeonesShade commented Mar 21, 2024

nice, should be fixed
btw should i wait for #9633 in doing the ui? I can probably make my own (at least good enough for now)

@SomeonesShade SomeonesShade marked this pull request as draft March 30, 2024 01:50
@SomeonesShade
Copy link
Contributor Author

this pr would be repurposed for just rtg buffs directly, I'll probably drop the hjson support since I'm not qualified for it (unless it already does work)

@SomeonesShade SomeonesShade changed the title Added itemDurationMultipliers to ConsumeGenerator RTG Buffs via ItemDurationMultiplier Oct 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants