Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding custom renderer #15

Open
DavoCg opened this issue Oct 1, 2023 · 1 comment
Open

Adding custom renderer #15

DavoCg opened this issue Oct 1, 2023 · 1 comment

Comments

@DavoCg
Copy link

DavoCg commented Oct 1, 2023

Hi,

first of all thanks for this light package that does very well what it aims to. Would you consider adding the ability to add custom renderer for every primitives ? While it might not be useful for boolean, it can be nice for string value (ex: you want to wrap an url in an )

The change could be pretty simple, happy to open a PR if it's something you consider adding.

Thanks

@AnyRoad
Copy link
Owner

AnyRoad commented Oct 6, 2023

Hi,

Thank you for the suggestion! it is definitely good to make library more versatile, my main concerns are performance and library size. I think if by default (without any cusom renderers) library will be same fast and it will not increase bundle size too much then PR is more than welcome!

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants