Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Display a notification when service stops #22

Closed
rouvoy opened this issue Dec 17, 2017 · 8 comments
Closed

Display a notification when service stops #22

rouvoy opened this issue Dec 17, 2017 · 8 comments

Comments

@rouvoy
Copy link
Contributor

rouvoy commented Dec 17, 2017

When the service stops to gather measurements, a notification should be displayed to indicate the user the app stops and she can restart it to keep gathering measurements.

@kaal-dam
Copy link
Contributor

since sensor services must be foreground service to prevent system to kill them and let user know that they are active
knowing that foreground service must have a notification displayed as long as they are running due to Android policy

displaying a notification when service stop is technically not necessary and may even be confusing

@rouvoy
Copy link
Contributor Author

rouvoy commented Jan 19, 2018

I do not remember the issue I faced but, as far as I remember, I think this is related to issue #29.

What if the user switch to another app, while keeping gathering measurements from connected sensor?

@kaal-dam
Copy link
Contributor

for #29 displaying i agree that a notification if connection with sensor is lost can be useful

i don't remember exactly what happen when the user switch to another app but as far as i remember the notification saying that the service is running is still present, since it's the service who save data into the database not the "app" itself it should mean that the measurements are still collected and saved.

i can't test it with the latest version of the in-dev app

@rouvoy
Copy link
Contributor Author

rouvoy commented Jan 19, 2018

Can we schedule a release embedding the latest changes so we can test in production?

@kaal-dam
Copy link
Contributor

With @Sparow199 we think we may be able to do a release next week on Friday afternoon/evening

@rouvoy
Copy link
Contributor Author

rouvoy commented Jan 19, 2018

Can you send an email to Suzanne? In order to see if that's fine with her?

@kaal-dam
Copy link
Contributor

Ok I send her an email, however in all cases it is not possible for us to release earlier

@aoudiamoncef
Copy link
Contributor

i extended show sticky notification when running IOIO service for Android 26 < (should be tested in different devices, @kaal-dam and i have only Andoid 26> devices)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants