Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MBAP header is read without regard to host endianness. #123

Open
iamalexcater opened this issue Jul 18, 2024 · 0 comments
Open

MBAP header is read without regard to host endianness. #123

iamalexcater opened this issue Jul 18, 2024 · 0 comments
Labels
v6

Comments

@iamalexcater
Copy link

Class: ModbusTcpRequestHandler

BitConverter.IsLittleEndian ought to be consulted when reading the MBAP header in TryReceiveRequestAsync().

The WriteFrame(...) method already does this when writing the header.
@Apollo3zehn Apollo3zehn added the v6 label Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
v6
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Apollo3zehn @iamalexcater