Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing symbols #177

Open
ScarlettGatelyMoore opened this issue Sep 21, 2022 · 5 comments
Open

Missing symbols #177

ScarlettGatelyMoore opened this issue Sep 21, 2022 · 5 comments

Comments

@ScarlettGatelyMoore
Copy link
Contributor

Hello! I am updating the package in debian and I have come across some missing symbols. From what I can see these are public:
c++filt _ZN8appimage4core4impl14PayloadIStreamC1Ev
appimage::core::impl::PayloadIStream::PayloadIStream()
c++filt _ZN8appimage4core4impl14PayloadIStreamC2Ev
appimage::core::impl::PayloadIStream::PayloadIStream()

Is this an internal call? Or do I have ABI breakage?

c++filt ZNK5boost10filesystem28recursive_directory_iterator5equalERKS1
boost::filesystem::recursive_directory_iterator::equal(boost::filesystem::recursive_directory_iterator const&) const
seems internal tests?

the rest are optional and not issues.

Thanks for any help in the matter.
Scarlett

@TheAssassin
Copy link
Member

I wonder how you detected these changes. Are you experiencing linking issues against other software? I'm not entirely sure how Debian handles C++ symbols.

I guess we need to rework how we export public symbols and need to hide all internal calls properly.

@ScarlettGatelyMoore
Copy link
Contributor Author

@TheAssassin
Copy link
Member

This confirms my assumption. We need to properly export symbols before generating symbol files makes any sense.

@ScarlettGatelyMoore
Copy link
Contributor Author

Any news on this?

@ScarlettGatelyMoore
Copy link
Contributor Author

Even if you can confirm they are all internal and not exposed to public I can continue. Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants