-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issues when not bundling libgdk_pixbuf-2.0.so.0 #475
Comments
From my general experience, libgdk* needs to be treated the same as libgtk* and libatk* - either bundle all of them or none of them. And slnce even major versions of the Gtk 3 series have proven not to be ABI and API compatible throughout the 3.x series, we have basically started treating them as something we need to bundle privately. So probably you are right. Commenting it out for now, but let's watch out for unintended side effects. |
Still actual. I fixed by: ingredients:
...
script:
- awk -i inplace 'BEGIN { RS = ""; FS = "\n" } !/Package: libgdk-pixbuf2.0-0/ { print $0 "\n" }' status
- awk -i inplace 'BEGIN { RS = ""; FS = "\n" } !/Package: libcairo2/ { print $0 "\n" }' status
- awk -i inplace 'BEGIN { RS = ""; FS = "\n" } !/Package: libgtk/ { print $0 "\n" }' status
- awk -i inplace 'BEGIN { RS = ""; FS = "\n" } !/Package: libgdk/ { print $0 "\n" }' status
- awk -i inplace 'BEGIN { RS = ""; FS = "\n" } !/Package: libatk/ { print $0 "\n" }' status
- awk -i inplace 'BEGIN { RS = ""; FS = "\n" } !/Package: gtk/ { print $0 "\n" }' status |
I think this library has to be removed from the excludelist again. It actively breaks Xournal++ 1.0.20. When it uses the system-provided library on focal (20.04), it segfaults (or, when run via gdb, doesn't show any icons).
The rule is 5+ years old and there is no real explanation nearby. Also, linuxdeploy-plugin-gtk force-deploys this library now to work around portability issues. I've checked that adding a copy of the bionic pixbuf library to the AppDir makes it work fine on focal as well.
Is there a good reason to keep it or can we just remove it?
CC @probonopd
References:
https://github.com/linuxdeploy/linuxdeploy-plugin-gtk/blob/7a439095785d25fc661ebd14db5d9c9bdf85838e/linuxdeploy-plugin-gtk.sh#L156-L177
The text was updated successfully, but these errors were encountered: