Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add libpam.so.0 and libpam_misc.so.0 to exclude list #558

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Zaraka
Copy link
Contributor

@Zaraka Zaraka commented Oct 2, 2024

Pam libraries are system specific, when using bundled PAM libs from e.g. fedora on Debian you can get an error such as Authentication failed: Module is unkown. Using system PAM libraries works completely fine, also If the system doesn't have PAM libraries I do not think PAM works at all, so there should not be any reason to bundle them.

@probonopd
Copy link
Member

What happens if an application requires libpam.so.0 and it is not on the system?

@Zaraka
Copy link
Contributor Author

Zaraka commented Oct 2, 2024

What happens if an application requires libpam.so.0 and it is not on the system?

well if it is a direct linkage it will fail, so I'm not sure I understand your question. I argue that bundled libpam will always be useless as that won't make PAM on the client Linux suddenly work. Each Distro will probably have a completely different PAM setup, the only thing it will share will be the modules and I'm certain they will be shared only with name and 'API', not the implementation.
So if you are trying to use AppImage that requires PAM on a system that doesn't have PAM, you are probably doing something wrong.

@probonopd
Copy link
Member

I don't care about PAM working, as long as the application will run. But if a system lacks libraries that the application links to, then the application will fail to run. And that's what we want to avoid.

@Zaraka
Copy link
Contributor Author

Zaraka commented Oct 2, 2024

but with your argument excludelist has to be empty, because what if user links to libX11.so.6 for example?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants