Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Torus as boundary Feature #9

Open
BHill96 opened this issue Oct 8, 2020 · 1 comment
Open

Add Torus as boundary Feature #9

BHill96 opened this issue Oct 8, 2020 · 1 comment
Labels
enhancement New feature or request

Comments

@BHill96
Copy link
Contributor

BHill96 commented Oct 8, 2020

It is currently used to draw vortex rings pre-sim, but would be a cool object to add. This would require #6 to be implemented first to use for generate_draw_geom.

@BHill96 BHill96 added the enhancement New feature or request label Oct 8, 2020
@markstock
Copy link
Collaborator

It sounds like having a non-class set of functions for geometry generation: cube/rectangle, sphere, and torus would go there. It would accept some basic parameters and return an ElementPacket. Let another function scale, rotate, and translate them into position.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants