Matter Condenser deletes items above storage cell limit if output is full

[adaexec]

Describe the bug

When a matter condenser has a 1k Storage Component in it and is set to produce matter balls (probably also works with singularities, haven't tested this), and 25600 Items (the amount needed for 100 of matter balls) are inserted without the output being cleared, the Matter Condenser will produce 64 matter balls and continue to store energy. When the energy reaches the maximum of the Storage Component, all further items will still be accepted, but will just be destroyed.

How to reproduce the bug

• Put a 1k Storage Component into a Matter Condenser
• Set the Matter Condenser to produce Matter Balls
• Pump 25600 Items into it without taking anything from the output
• Take the entire output out of the machine
• The Output will be 96 Matter Balls (1.5 Stacks)

Expected behavior

The Matter Condenser should not accept any more items than the Storage Component can hold, or this behavior should be documented in the Guide. The Guide currently states "Matter balls take 256 items or buckets each, so a 1k ME Storage Component (which provides 8192 bits of capacity) is more than enough."

Additional details

I had this problem in the Modpack All the Mods 10

Which minecraft version are you using?

1.21

On which mod loaders does it happen?

NeoForge

Crash log

https://gist.github.com/adaexec/ee3c819a7b70828731cbafd29c28d2e0

[Mithi83]

The code seems to back up your observation. It can only occur though if you have no automated method of extracting the matter balls and the storage component actually fills up. If that is a deliberate design choice or an oversight is not clear. Maybe it is a performance optimization that anticipates a certain use case. Adding a more conservative approach that does not accept additional input items will be more complex. Maybe it is also the intention that it should work as a trash can with some extras.

In a typical setup I would expect to have some automation around the condenser, e.g. an unlimited supply of cobblestone or water (ATM 10 has a special ME cells you can craft for that or the sink) and an import bus to extract the finished matter balls.

[adaexec]

I actually have an import bus that extracts the matter balls, but the warm-up time is too long, causing the issue. My auto-crafting is inserting the items faster than the import bus can import the matter balls.

I've worked around the problem by just using a bigger storage component in the condenser, but if it is a deliberate design choice I think that it should be documented inside the in-game guide, where it currently states that a 1k storage component is more than enough.