Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Rewrite Reactivity Logic #13

Open
1 task done
DeepanshKhurana opened this issue Jun 12, 2024 · 0 comments
Open
1 task done

[Feature]: Rewrite Reactivity Logic #13

DeepanshKhurana opened this issue Jun 12, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@DeepanshKhurana
Copy link
Member

Guidelines

  • I agree to follow this project's Contributing Guidelines.

Description

Based on @Gotfrid's comment on #12

Another comment (out of scope of this PR) I have is related to a pattern that I see in main.R and which I find weird: > observeEvent(..., { renderUI(mod$ui()); mod$server() }
Would it be cleaner if you create ui+server for a particular app section only once, and inside a corresponding server you decide what to render by passing a reactive key, e.g. state$selected_app()$guid?

Problem

The reactivity logic is awkward and can be streamlined a bit as Pavel suggests.

Proposed Solution

We could take Pavel's suggestion to have the reactiveValues inside the modules instead if having the current mechanism does not offer a clear advantage.

Alternatives Considered

N/A

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant