Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rhino docs show two search boxes #601

Closed
kamilzyla opened this issue Jul 16, 2024 · 0 comments · Fixed by #604
Closed

Rhino docs show two search boxes #601

kamilzyla opened this issue Jul 16, 2024 · 0 comments · Fixed by #604

Comments

@kamilzyla
Copy link
Collaborator

kamilzyla commented Jul 16, 2024

Problem

image

Cause

The problem seems to have appeared after #597 was merged. A bump of RoxygenNote from 7.2.3 to 7.3.1 in this commit might have resulted in newer pkgdown dependencies being installed in the pkgdown.yml workflow after the merge which probably caused the problem to appear.

I had trouble reproducing the issue locally but I was finally able to do it by installing all the packages with the exact versions as printed in the log files of pkgdown.yml workflow. The issue seems to only appear when the site is built with pkgdown/build.R which is our solution for showing multiple documentation versions (#575). Probably the navbar_template.html was updated in {pkgdown} causing our copy to malfunction.

Possible approaches

  1. Update navbar_template.html.
  2. Inject the version switcher using before_navbar as discussed in this comment (avoid keeping a copy of a template).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant