Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make showcase mode working [nice to have] #202

Open
dokato opened this issue Jun 25, 2020 · 2 comments
Open

make showcase mode working [nice to have] #202

dokato opened this issue Jun 25, 2020 · 2 comments
Assignees

Comments

@dokato
Copy link
Contributor

dokato commented Jun 25, 2020

Create our own showcase mode working with semantic css.

======
OLD VERSION OF THE TASK

Currently when running apps in showcase mode, one gets sth like this:

runApp("examples/calendar/", display.mode = "showcase")

Screenshot 2020-06-25 at 10 17 42

This problem occures probably due to fomatnic / boostrap incompatibility. Maybe some wrapper is required?

@krystian8207
Copy link
Contributor

krystian8207 commented Jul 3, 2020

@dokato I've checked what's the reason for this behavior. Suppressing bootstrap is not the problem, but generally loading fomantic css breaks the original styling used in the showcase. One of my ideas for solving this would be to create our custom showcase mode, properly styled with fomantic framework. wdyt?

@dokato dokato closed this as completed Jul 9, 2020
@dokato dokato reopened this Jul 9, 2020
@olgamie olgamie changed the title make showcase mode working make showcase mode working [nice to have] Aug 13, 2020
@esraay
Copy link
Contributor

esraay commented Nov 7, 2022

I guess we all agree on writing our own showcase system that would be based on the semantic library. We need to find a way for shiny::runApp() to use the new showcase system. The only plausible solution we can think of would have been to trace shiny::showcaseUI() or shiny::renderPage(), just like bspm::enable() does. However, as neither of them is being exported by shiny, we don't think tracing would work.

Does anyone with an idea on how to integrate a custom-made showcase into the shiny::runApp() workflow?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants