-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AccessKit: Pause animated webp images #1401
Comments
This shouldn't be a new option. If the "Pause GIFs" option doesn't work on uploaded WEBP, that's an oversight. I'm not sure we have any methods available to determine if a WEBP is animated or not, though... |
We don't have a way to determine if GIFs are animated, to be fair; we just assume they are :D I don't think there's a way that doesn't involve looking at the binary, and I can't remember if you can even do that in a web extension. Might only be doable if Tumblr staff specifically adds some sort of indicator in the code to animated images, which seems unlikely. |
Hmm... I wonder if we can just... apply the same assumption to WEBP. Why would anyone be uploading still images as WEBP? Tumblr certainly doesn't ever convert still images to WEBP. Actually, do single-frame GIFs and WEBPs even stay as GIFs and WEBPs when uploaded? |
If they downloaded them from a site that transcodes, probably. My guess is that there are a quite small number of them now, but that might change in the future (yes, it sure seems like WebP lost the format wars, but you never know). Still might be good enough though. I do sometimes see us processing still GIFs. A version of this that applies to GIFs could also be a thing. Then again, we could always just apply-to-all and revert that if or when that starts becoming a thing. You know, if this script, XKit Rewritten and Tumblr exist then. I think that seems like the most reasonable option.
I wouldn't assume that to be true forever, backlash over image downloading aside. Again, though, can always just revert if it happens.
As alluded to, yes. I have seen single-frame GIFs in the wild, and I tested a WebP upload. (I didn't get around to digging up or creating all four variants and putting them into a test post to link here yet.) |
Concept
Same as the Pause GIFs option, but applicable to animated webp.
The text was updated successfully, but these errors were encountered: