Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Kill use of portOutputRegister, digitalPinToPort, and digitalPinToBitMask functions #22

Open
joshgoebel opened this issue Jun 11, 2015 · 0 comments
Open

Kill use of portOutputRegister, digitalPinToPort, and digitalPinToBitMask functions #22

joshgoebel opened this issue Jun 11, 2015 · 0 comments
Labels
Flash Size

Comments

@joshgoebel
Copy link
Collaborator

If we hard code these values there is an easy 72 bytes to be had back - that is just the PROGMEM storage we get back from killing those large lookup tables. The main reason for them to be so abstracted is to support different chips with different port configurations. If we're pretty much locked into the Atmega32U4 for the foreseeable future these could easily be swapped out for hard-wired constants and that space could be used for more ambitious programs.

Thoughts?
@joshgoebel joshgoebel changed the title [Size] Kill portOutputRegister, digitalPinToPort, and digitalPinToBitMask utility functions [Size] Kill use of portOutputRegister, digitalPinToPort, and digitalPinToBitMask functions Jun 11, 2015
@joshgoebel joshgoebel modified the milestone: 1.1 Feb 10, 2016
@shogerr shogerr changed the title [Size] Kill use of portOutputRegister, digitalPinToPort, and digitalPinToBitMask functions Kill use of portOutputRegister, digitalPinToPort, and digitalPinToBitMask functions Feb 16, 2016
@shogerr shogerr modified the milestones: 1.2, 1.1 Feb 20, 2016
@joshgoebel joshgoebel modified the milestone: 1.2 Feb 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Flash Size
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@joshgoebel @shogerr