Couple more periods that should be colons

[lanery]

couple more periods that should be colons

Couple more periods that should be colons....

[lanery]

For something like this is it ok to bypass review?

[keithchev]

For something like this is it ok to bypass review?

I'm not sure if we have any formal policy about this, but fwiw my own feeling is the answer should be basically no, unless it's really urgent and you really can't find anyone who can approve your PR. The reason is that it's just so much simpler to have a rule and always stick to it. As soon as we allow for exceptions, we both erode the authority of the rule and also have to grapple with the ambiguity of what constitutes "something like this". And ultimately that means we have to rely on individuals to make judgement calls, with all the possibilities for misunderstandings, conflicting intuitions, etc, that come with that. And so my feeling is that any time we can use a rule or protocol to avoid that at little/no cost, then we're wise to use it.

[lanery]

For something like this is it ok to bypass review?

I'm not sure if we have any formal policy about this, but fwiw my own feeling is the answer should be basically no, unless it's really urgent and you really can't find anyone who can approve your PR. The reason is that it's just so much simpler to have a rule and always stick to it. As soon as we allow for exceptions, we both erode the authority of the rule and also have to grapple with the ambiguity of what constitutes "something like this". And ultimately that means we have to rely on individuals to make judgement calls, with all the possibilities for misunderstandings, conflicting intuitions, etc, that come with that. And so my feeling is that any time we can use a rule or protocol to avoid that at little/no cost, then we're wise to use it.

Nicely explained and very reasonable -- thanks!