Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rl/regression on all stats #35

Merged
merged 4 commits into from
Oct 10, 2024
Merged

Rl/regression on all stats #35

merged 4 commits into from
Oct 10, 2024

Conversation

lanery
Copy link
Collaborator

@lanery lanery commented Oct 10, 2024

This PR updates notebook 2 to include regression statistics on all metrics. It also includes these stats in a CSV file in the results directory.

PR checklist

  • Describe the changes you've made.

- add regression stats for all metrics, while still only plotting those in the pub (Figure 4)
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@lanery lanery requested a review from taraeb October 10, 2024 22:44
@taraeb
Copy link

taraeb commented Oct 10, 2024

Great, thanks for adding the regression on all 11 metrics and exporting the CSV file so that we can link to it as Supplemental Table 1 in the associated pub.

@lanery lanery merged commit 5761ae2 into main Oct 10, 2024
1 check passed
@lanery lanery deleted the rl/regression-on-all-stats branch October 10, 2024 23:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants