Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix for converter registration #66

Merged
merged 4 commits into from
May 30, 2024
Merged

Bug fix for converter registration #66

merged 4 commits into from
May 30, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented May 30, 2024

Fixes issue where the same file can be imported from different file paths (i.e. by pytest)

Copy link

codecov bot commented May 30, 2024

Codecov Report

Attention: Patch coverage is 71.42857% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 92.63%. Comparing base (1e75998) to head (22246a3).

Files Patch % Lines
fileformats/core/mixin.py 60.00% 1 Missing and 1 partial ⚠️
fileformats/core/utils.py 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #66      +/-   ##
==========================================
- Coverage   92.66%   92.63%   -0.04%     
==========================================
  Files          45       45              
  Lines        4911     4915       +4     
  Branches      547      547              
==========================================
+ Hits         4551     4553       +2     
- Misses        270      272       +2     
  Partials       90       90              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 8fc9dc9 into main May 30, 2024
25 of 26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant