Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardens mtime_cached_property to invalidate the cache for poor mtime resolutions #76

Merged
merged 16 commits into from
Sep 12, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 11, 2024

  • Guesses the mtime resolution from the file system type (taking conservative estimates, e.g. ext4 -> 1 sec)
  • Checks that enough time has passed since the last of the cached mtimes to be sure that no writes could have occurred between re-reads and the mtimes stay the same

Copy link

codecov bot commented Sep 11, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 6 lines in your changes missing coverage. Please review.

Project coverage is 92.34%. Comparing base (5b84d2b) to head (356ca38).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/core/decorators.py 92.30% 3 Missing and 1 partial ⚠️
fileformats/image/raster.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
- Coverage   92.34%   92.34%   -0.01%     
==========================================
  Files          43       44       +1     
  Lines        5084     5108      +24     
  Branches      557      560       +3     
==========================================
+ Hits         4695     4717      +22     
- Misses        294      296       +2     
  Partials       95       95              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 86f0f68 into main Sep 12, 2024
17 checks passed
@tclose tclose deleted the negative-file-offsets branch September 12, 2024 04:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant