Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added TypedCollection base class #85

Merged
merged 3 commits into from
Sep 20, 2024
Merged

Added TypedCollection base class #85

merged 3 commits into from
Sep 20, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 20, 2024

  • Permit Optional content types for TypedSet and TypedDirectory for content types that can appear (and will be listed in the contents) but aren't required

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

Attention: Patch coverage is 85.49618% with 19 lines in your changes missing coverage. Please review.

Project coverage is 92.22%. Comparing base (f5bf5e6) to head (233d079).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/core/mock.py 56.66% 11 Missing and 2 partials ⚠️
fileformats/core/utils.py 63.63% 2 Missing and 2 partials ⚠️
fileformats/core/collection.py 98.07% 1 Missing ⚠️
fileformats/generic/directory.py 90.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #85      +/-   ##
==========================================
- Coverage   92.25%   92.22%   -0.03%     
==========================================
  Files          45       47       +2     
  Lines        5255     5313      +58     
  Branches      597      612      +15     
==========================================
+ Hits         4848     4900      +52     
- Misses        301      304       +3     
- Partials      106      109       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 542c75c into main Sep 20, 2024
17 checks passed
@tclose tclose deleted the typed-collection branch September 20, 2024 07:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant