Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Self in extras signature matching #89

Merged
merged 6 commits into from
Sep 27, 2024

put python version checks before trying to import from typing_extensions

735f24f
Select commit
Loading
Failed to load commit list.
Merged

Handle Self in extras signature matching #89

put python version checks before trying to import from typing_extensions
735f24f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Sep 27, 2024 in 0s

92.30% (+0.08%) compared to 1428be7

View this Pull Request on Codecov

92.30% (+0.08%) compared to 1428be7

Details

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.

Project coverage is 92.30%. Comparing base (1428be7) to head (735f24f).

Files with missing lines Patch % Lines
fileformats/core/datatype.py 0.00% 1 Missing and 1 partial ⚠️
fileformats/core/collection.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   92.21%   92.30%   +0.08%     
==========================================
  Files          47       47              
  Lines        5307     5317      +10     
  Branches      608      610       +2     
==========================================
+ Hits         4894     4908      +14     
+ Misses        304      299       -5     
- Partials      109      110       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.