Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle negative magic number offsets in sample file generation #90

Merged
merged 3 commits into from
Sep 27, 2024

Conversation

tclose
Copy link
Contributor

@tclose tclose commented Sep 27, 2024

No description provided.

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 4 lines in your changes missing coverage. Please review.

Project coverage is 92.26%. Comparing base (d1916d1) to head (4fee622).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
fileformats/generic/generate_sample_data.py 66.66% 2 Missing and 1 partial ⚠️
fileformats/core/sampling.py 85.71% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #90      +/-   ##
==========================================
- Coverage   92.30%   92.26%   -0.05%     
==========================================
  Files          47       47              
  Lines        5317     5326       +9     
  Branches      610      612       +2     
==========================================
+ Hits         4908     4914       +6     
- Misses        299      301       +2     
- Partials      110      111       +1     
Flag Coverage Δ
92.18% <75.00%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tclose tclose merged commit 06eb686 into main Sep 27, 2024
16 of 17 checks passed
@tclose tclose deleted the touch-ups branch September 28, 2024 03:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant