Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for a RepositoryMap.json #19

Open
Ardesco opened this issue Nov 4, 2014 · 8 comments
Open

Add support for a RepositoryMap.json #19

Ardesco opened this issue Nov 4, 2014 · 8 comments
Assignees
Milestone

Comments

@Ardesco
Copy link
Owner

Ardesco commented Nov 4, 2014

Just because json is so much nicer than xml.

@Ardesco Ardesco self-assigned this Nov 4, 2014
@Ardesco Ardesco added this to the 1.0.5 milestone Nov 4, 2014
@Ardesco Ardesco modified the milestones: 1.0.7, 1.0.5 Mar 29, 2015
@Ardesco
Copy link
Owner Author

Ardesco commented Feb 26, 2016

Or maybe YAML, or TOML...

@Ardesco Ardesco modified the milestones: 1.1.0, 1.0.7 Feb 26, 2016
@haroon-sheikh
Copy link
Contributor

@Ardesco I've started working on this with YAML which looks a bit like this?

windows:
  -
    name: chromedriver
    version: 2.33
    fileLocation: https://chromedriver.storage.googleapis.com/2.33/chromedriver_win32.zip
    hash: f6a0d7939355acba00f7b1374bebda50bbead59b
    hashType: sha1
    bitrate:
      - 32bit
      - 64bit
osx:
  -
    name: chromedriver
    version: 2.33
    fileLocation: https://chromedriver.storage.googleapis.com/2.33/chromedriver_win32.zip
    hash: f6a0d7939355acba00f7b1374bebda50bbead59b
    hashType: sha1
    bitrate:
      - 32bit
      - 64bit

Are we happy with YAML? if yes, shall we deprecate xml completely and plan 2.0.0 of the plugin?

@Ardesco
Copy link
Owner Author

Ardesco commented Nov 20, 2017

I've already got a JSON fork which is what I was planning for 2.0.0.

I'm expecting the new structure to look like this:

{
  "linux": [
    {
      "name": "phantomjs",
      "version": "2.1.1",
      "architecture": "64bit",
      "location": "https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-i686.tar.bz2",
      "validation": {
        "hash": "f8afc8a24eec34c2badccc93812879a3d6f2caf3",
        "hashType": "sha1"
      }
    },
    {
      "name": "phantomjs",
      "version": "2.1.0",
      "architecture": "64bit",
      "location": "https://bitbucket.org/ariya/phantomjs/downloads/phantomjs-2.1.1-linux-i686.tar.bz2",
      "validation": {
        "hash": "f8afc8a24eec34c2badccc93812879a3d6f2caf3",
        "hashType": "sha1"
      }
    }
  ]
}

@Ardesco
Copy link
Owner Author

Ardesco commented Nov 20, 2017

Yes I know the data is junk atm, it's just a structure example :)

@haroon-sheikh
Copy link
Contributor

Oh great! I'll just halt YAML then. ;)

How far are you with 2.0.0?

@haroon-sheikh
Copy link
Contributor

Also when versioning, we should keep http://semver.org/ in mind. E.g. Java 8 changes should really have been a breaking change.

@Ardesco
Copy link
Owner Author

Ardesco commented Nov 20, 2017

I'm aware of semver, the only reason the plugin went to java 8 only is because selenium went to java 8 only.

It's technically a breaking change, but there's no java 8 specific code in the plugin. You could still run it with Java 7, but Selenium won't work.

It's not really worth changing the major version number because another project changed their dependencies. nothing has really changed in the plugin.

@mpkorstanje
Copy link
Contributor

While the plugin is not using any java 8 features it is compiled using the java 8 class file format (major version 52). This is not understood by java 7 (major version 51). You can however use java 7 compiled code in java 8.

As long as the project using selenium is using java 8 I would expect selenium to keep on working. So I am not sure why this was done in the first place.

That aside, major version numbers don't cost anything. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants