AP_RPM: Demystifying RPM sensors #27306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Jun 14, 2024
MattKear
force-pushed
the
pr_rpm_logging
branch
2 times, most recently
from
6594c10 to
9590e55
Compare
|
This has now been flight tested on heli: |
tridge
approved these changes
Jul 3, 2024
IamPete1
reviewed
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lots of users struggle with setting up interrupt-based RPM sensors. (see here for a number of users asking for help: https://discuss.ardupilot.org/t/rpm-sensor-wiki-knowledge-share/45091/83).
In an attempt to demystify RPM sensors, this PR improves the logging:
It is my hope that adding this information will help users to figure out what is going wrong.
Example from Testing:
Tested IRL on Heli.
Thankfully I had a dodgy RPM sensor for testing 😬
So now, by always logging raw RPM I can see that something is not right in the measurement and I can see that the corresponding quality is measure is on the floor.
Here is an example of the 2nd instance working as well:
