SITL: fix json airspeed #27476
SITL: fix json airspeed #27476
Conversation
|
@tridge, Could you please take a look at this? My Gazebo simulation is not working anymore, and I think I've figured out why. |
eppravitra
force-pushed
the
json-airspeed
branch
2 times, most recently
from
c0420d5 to
5093f4e
Compare
|
Thanks for the suggestions @IamPete1. I think you are right about the changes. Could you add bug and DevCall labels to this, since Gazebo sim is broken right now? |
Airspeed calculation for JSON was not quite working because velocity_air_ef was not updated in SIM_JSON.cpp Update libraries/SITL/SIM_JSON.cpp Co-authored-by: Peter Hall <[email protected]> Update libraries/SITL/SIM_JSON.cpp Co-authored-by: Peter Hall <[email protected]> comment changes remove redundant airspeed calculation
|
|
||
| // airspeed | ||
| airspeed = velocity_air_bf.length(); |
There was a problem hiding this comment.
I see other backends still updating these; why do we no longer need to do that here?
There was a problem hiding this comment.
The calculation is already done inside update_eas_airspeed(). If left as it is, the variable airspeed will be
rewritten anyway. I figure it's better to remove the line to avoid confusion.
|
@IamPete1 are you OK with this now? |
There was a problem hiding this comment.
LGTM, thanks.
@peterbarker Yeah, I think its good to merge.
|
Merged, thanks! |
|
Thanks! |
Airspeed calculation for JSON was not quite working because velocity_air_ef was not updated in SIM_JSON.cpp