AP_Mission: Allow Param4 to be uploaded with NaN #27482
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Presumably we don't actually manage to store NaN, and we always ignore this field? I guess technically that means we should be bouncing any attempt to upload a waypoint without this field? I'm not suggesting we make that change as it will break vast amounts of stuff... |
|
AP doesn't currently make use of that field - it is not stored. At the moment, any mission containing LOITER_UNLIM must have a non-nan p4 field for the mission upload to succeed. MAVLink specification allows for that particular field in the message to be nan There is possibly other waypoint types that may cause an entire mission to upload if the users selected ground station does not support the AP implementation of those messages. |
By default, QGroundControl will attempt to upload Loiter Unlimited with a NaN in param4. Given this field could be NaN, we allow it through the parser. See: https://mavlink.io/en/messages/common.html#MAV_CMD_NAV_LOITER_UNLIM
peterbarker
force-pushed
the
pr/allow_loiter_unlimited_with_nan_in_param_4
branch
from
f4d37f2 to
1a66511
Compare
peterbarker
approved these changes
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, QGroundControl will attempt to upload Loiter Unlimited with a NaN in param4.
Given this field could be NaN, we allow it through the parser.
See Param4 in https://mavlink.io/en/messages/common.html#MAV_CMD_NAV_LOITER_UNLIM