From 93b41ddda067ce42114e54a8ec6262bcfab56e17 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 6 Jul 2024 09:02:41 +1000 Subject: [PATCH 1/6] AP_HAL_ChibiOS: removed run_debug_shell --- libraries/AP_HAL_ChibiOS/Util.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libraries/AP_HAL_ChibiOS/Util.h b/libraries/AP_HAL_ChibiOS/Util.h index 8e431484a096d..1df3e32c767de 100644 --- a/libraries/AP_HAL_ChibiOS/Util.h +++ b/libraries/AP_HAL_ChibiOS/Util.h @@ -37,7 +37,6 @@ class ChibiOS::Util : public AP_HAL::Util { return static_cast(util); } - bool run_debug_shell(AP_HAL::BetterStream *stream) override { return false; } uint32_t available_memory() override; // get path to custom defaults file for AP_Param From 504b9fc068b943e361f0026df6870cbb01bbe3df Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 6 Jul 2024 09:02:41 +1000 Subject: [PATCH 2/6] AP_HAL_Empty: removed run_debug_shell --- libraries/AP_HAL_Empty/Util.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/libraries/AP_HAL_Empty/Util.h b/libraries/AP_HAL_Empty/Util.h index 3dae90c2f82e5..55e590a20e37b 100644 --- a/libraries/AP_HAL_Empty/Util.h +++ b/libraries/AP_HAL_Empty/Util.h @@ -4,6 +4,4 @@ #include "AP_HAL_Empty_Namespace.h" class Empty::Util : public AP_HAL::Util { -public: - bool run_debug_shell(AP_HAL::BetterStream *stream) override { return false; } }; From 982ff3d0bbdc602b8cb12a3460629945eff2e38c Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 6 Jul 2024 09:02:41 +1000 Subject: [PATCH 3/6] AP_HAL: removed run_debug_shell --- libraries/AP_HAL/Util.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/libraries/AP_HAL/Util.h b/libraries/AP_HAL/Util.h index da22f1a8be1d9..1d2fcdafce737 100644 --- a/libraries/AP_HAL/Util.h +++ b/libraries/AP_HAL/Util.h @@ -44,11 +44,6 @@ class AP_HAL::Util { // set command line parameters to the eeprom on start virtual void set_cmdline_parameters() {}; - // run a debug shall on the given stream if possible. This is used - // to support dropping into a debug shell to run firmware upgrade - // commands - virtual bool run_debug_shell(AP_HAL::BetterStream *stream) = 0; - enum safety_state : uint8_t { SAFETY_NONE, SAFETY_DISARMED, From 0d7b8e5d0680dc54f0fd31dd5522e894ce20e2a1 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 6 Jul 2024 09:02:41 +1000 Subject: [PATCH 4/6] AP_HAL_Linux: removed run_debug_shell --- libraries/AP_HAL_Linux/Util.h | 1 - 1 file changed, 1 deletion(-) diff --git a/libraries/AP_HAL_Linux/Util.h b/libraries/AP_HAL_Linux/Util.h index 9aa0a82314678..70faada85b601 100644 --- a/libraries/AP_HAL_Linux/Util.h +++ b/libraries/AP_HAL_Linux/Util.h @@ -29,7 +29,6 @@ class Util : public AP_HAL::Util { } void init(int argc, char *const *argv); - bool run_debug_shell(AP_HAL::BetterStream *stream) override { return false; } /** return commandline arguments, if available From 2fd823fee6414e33d783b90a15d1b27334fc2bef Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 6 Jul 2024 09:02:41 +1000 Subject: [PATCH 5/6] AP_HAL_SITL: removed run_debug_shell --- libraries/AP_HAL_SITL/Util.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libraries/AP_HAL_SITL/Util.h b/libraries/AP_HAL_SITL/Util.h index 588fc2a25a311..cbfbeda556670 100644 --- a/libraries/AP_HAL_SITL/Util.h +++ b/libraries/AP_HAL_SITL/Util.h @@ -17,10 +17,6 @@ class HALSITL::Util : public AP_HAL::Util { Util(SITL_State *_sitlState) : sitlState(_sitlState) {} - bool run_debug_shell(AP_HAL::BetterStream *stream) override { - return false; - } - /** how much free memory do we have in bytes. */ From d12dd01b01d905dde7dd179705c7d318d388bb50 Mon Sep 17 00:00:00 2001 From: Andrew Tridgell Date: Sat, 6 Jul 2024 09:03:56 +1000 Subject: [PATCH 6/6] HAL_ESP32: removed run_debug_shell --- libraries/AP_HAL_ESP32/Util.h | 4 ---- 1 file changed, 4 deletions(-) diff --git a/libraries/AP_HAL_ESP32/Util.h b/libraries/AP_HAL_ESP32/Util.h index 3360e1ad5a197..fcf83ec3b613a 100644 --- a/libraries/AP_HAL_ESP32/Util.h +++ b/libraries/AP_HAL_ESP32/Util.h @@ -28,10 +28,6 @@ class ESP32::Util : public AP_HAL::Util return static_cast(util); } - bool run_debug_shell(AP_HAL::BetterStream *stream) override - { - return false; - } uint32_t available_memory() override; // Special Allocation Routines