Copter: remove throttle check for arming in guided #28009
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IamPete1
reviewed
Sep 8, 2024
| @@ -1140,7 +1144,8 @@ class ModeGuided : public Mode { | |||
| DoNotStabilizePositionXY = (1U << 4), | |||
| DoNotStabilizeVelocityXY = (1U << 5), | |||
| WPNavUsedForPosControl = (1U << 6), | |||
| AllowWeatherVaning = (1U << 7) | |||
| AllowWeatherVaning = (1U << 7), | |||
| ArmingCheckThrottle = (1U << 8), | |||
There was a problem hiding this comment.
Fixed, thanks.
We really should add a sanity check for that.
|
Is there a case where we could be waiting for the pilot to raise throttle in a takeoff in guided mode? |
Co-authored-by: muramura <[email protected]> .... but add a guided option to put it back.
peterbarker
force-pushed
the
pr/netral-throttle-check
branch
from
90c4b7b to
f62cc23
Compare
|
We discussed this on the dev call and we think there is already an RC_OPTIONS that provides the same safety check |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored-by: muramura [email protected]
.... but add a guided option to put it back.
Replaces #20999
Closes #20995
We could ignore throttle unconditionally instead of adding the option bit?
New autotest fails before / passes after.