Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_Linux: keep "dfd" open util fsync is done. #28036

Merged
merged 1 commit into from
Sep 8, 2024

Conversation

junan76
Copy link
Contributor

@junan76 junan76 commented Sep 8, 2024

Since we want to do a fsync on "dfd", it can not be closed before that.

Since we want to do a fsync on "dfd", it can not be closed before that.

Signed-off-by: junan <[email protected]>
Copy link
Contributor

@peterbarker peterbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are also leaking a file descriptor if that fgtruncate fails.

@peterbarker peterbarker merged commit 4ee5b0e into ArduPilot:master Sep 8, 2024
61 checks passed
@junan76 junan76 deleted the pr/storage-double-close branch September 9, 2024 01:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants