Tools: update WSL2 use in uploader.py #28738
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterbarker
approved these changes
Nov 25, 2024
Tools/ardupilotwaf/chibios.py
Outdated
| @@ -103,7 +103,7 @@ def wsl2_prereq_checks(self): | |||
| except subprocess.CalledProcessError: | |||
| #if where.exe can't find the file it returns a non-zero result which throws this exception | |||
| where_python = "" | |||
| if not where_python or "\Python\Python" not in where_python or "python.exe" not in where_python: | |||
| if not where_python or "python.exe" not in where_python: | |||
There was a problem hiding this comment.
Suggested change
| if not where_python or "python.exe" not in where_python: | |
| if "python.exe" not in where_python: |
magicrub
force-pushed
the
pr/wsl2_update3
branch
from
fb287e4
to
8f7f93a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just got a new Windows 11 computer and did a fresh WSL2 install and could not push a binary to USB because "Python/Python" wasn't in the python.exe path. Not sure why that's in there, maybe it's because I installed 3.13 on the Windows side. Anyways, it's a stricter check that is unnecessary, all we care about is if we can call python.exe.