-
Notifications
You must be signed in to change notification settings - Fork 17.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AP_HAL_ChibiOS:add board support for CrazyF405 #28829
base: master
Are you sure you want to change the base?
AP_HAL_ChibiOS:add board support for CrazyF405 #28829
Conversation
@Hwurzburg i have created a clean commit you can review this and merge it.Thanks |
f56fe36
to
5cf1dad
Compare
its failing since you have not created a bootloader and placed in Tools/bootloaders |
Okk so according to previous conversation you said you can put bootloader in seperate commit right? |
yes...Tools: add CrazyF405 bootloader |
while you are at it change the bootloader files APJ_BOARD_ID to text |
Yeah I have done that in this commit |
MCU STM32F4xx STM32F405xx | ||
|
||
# board ID for firmware load | ||
APJ_BOARD_ID 1177 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
no, you did not change it to text.... It still needs the CrazyF405_bl.bin file added to Tools/bootloaders in order to be able to build the code and pass CI
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I've made the correction. I have a separate commit for the bootloader. I believe if you merge that first and then rerun the checks, they should pass successfully.
Hardware Description file for CrazyF405.