Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_HAL_ChibiOS:add board support for CrazyF405 #28829

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Srivenkateshwar
Copy link
Contributor

Hardware Description file for CrazyF405.

@Srivenkateshwar
Copy link
Contributor Author

Srivenkateshwar commented Dec 9, 2024

@Hwurzburg i have created a clean commit you can review this and merge it.Thanks
Also ,may i know why configure-all check was unsuccessful in order to understand where im getting wrong

@Hwurzburg Hwurzburg force-pushed the add-hwdef.dat-for-beatflightf4-hardware branch from f56fe36 to 5cf1dad Compare December 9, 2024 16:11
@Hwurzburg
Copy link
Collaborator

its failing since you have not created a bootloader and placed in Tools/bootloaders

@Srivenkateshwar
Copy link
Contributor Author

its failing since you have not created a bootloader and placed in Tools/bootloaders

Okk so according to previous conversation you said you can put bootloader in seperate commit right?

@Hwurzburg
Copy link
Collaborator

yes...Tools: add CrazyF405 bootloader

@Hwurzburg
Copy link
Collaborator

while you are at it change the bootloader files APJ_BOARD_ID to text

@Srivenkateshwar
Copy link
Contributor Author

while you are at it change the bootloader files APJ_BOARD_ID to text

Yeah I have done that in this commit

MCU STM32F4xx STM32F405xx

# board ID for firmware load
APJ_BOARD_ID 1177
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no, you did not change it to text.... It still needs the CrazyF405_bl.bin file added to Tools/bootloaders in order to be able to build the code and pass CI

Copy link
Contributor Author

@Srivenkateshwar Srivenkateshwar Dec 13, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I've made the correction. I have a separate commit for the bootloader. I believe if you merge that first and then rerun the checks, they should pass successfully.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants