Add wiki for Trimble PX-1 #5540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ryanf55
force-pushed
the
gsof-px1-wiki
branch
from
0e34ef1 to
bb3bc76
Compare
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
force-pushed
the
gsof-px1-wiki
branch
from
bb3bc76 to
8b99e71
Compare
Ryanf55
commented
Nov 8, 2023
Ryanf55
commented
Nov 11, 2023
|
|
||
| The following instructions assume the PX-1 is your first GPS. If you have configured it as a second GPS, change all parameter names. | ||
|
|
||
| - :ref:`GPS_COM_PORT <GPS_COM_PORT>` = 1 (to use COM2, the TTL output of the PX-1) or 3 (to use COM1, the RS232 output of the PX-1) |
There was a problem hiding this comment.
This param is now documented directly, and the description here can be removed.
|
@Ryanf55 is this ready to be changed from a draft to final PR? |
Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
commented
Dec 7, 2023
There was a problem hiding this comment.
@Hwurzburg Yes. I've updated the entry to match the current implementation. It can be merged now.
|
|
||
| The following instructions assume the PX-1 is your first GPS. If you have configured it as a second GPS, change all parameter names. | ||
|
|
||
| - :ref:`GPS_COM_PORT <GPS_COM_PORT>` = 1 (to use COM2, the TTL output of the PX-1) or 3 (to use COM1, the RS232 output of the PX-1) |
|
It wont be merged until 4.5...but will add a pointer to it in upcoming |
Hwurzburg
requested changes
Dec 7, 2023
| .. _common-gps-trimble-px1: | ||
|
|
||
|
|
||
| ===================== |
There was a problem hiding this comment.
just noticed tiltling over/underline wrong here and below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PX-1 needs a wiki entry. This should be merged together with ArduPilot/ardupilot#25479.
One thing I think the wiki does not do a good job with, that is more of an issue of parameters, is showing which parameters are driver-specific. In order to remove any confusion for PX-1 users, I have given a list of parameters which are known to be unsupported. If there is a better way of handling this, please share.