Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement] - Refactor players module #30

Merged
merged 11 commits into from
Mar 20, 2023
Merged

[Improvement] - Refactor players module #30

merged 11 commits into from
Mar 20, 2023

Conversation

ArielleMurad
Copy link
Owner

Resolves #23, #24

@ArielleMurad ArielleMurad added the improvement Improvements or additions to an existing feature label Mar 19, 2023
@ArielleMurad ArielleMurad added this to the v1.2.0 milestone Mar 19, 2023
ArielleMurad
ArielleMurad commented Mar 19, 2023
View reviewed changes
Copy link
Owner Author

@ArielleMurad ArielleMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 Requesting changes

ArielleMurad
ArielleMurad commented Mar 20, 2023
View reviewed changes
Copy link
Owner Author

@ArielleMurad ArielleMurad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Approved

@ArielleMurad ArielleMurad merged commit 241c3ee into main Mar 20, 2023
@ArielleMurad ArielleMurad deleted the 23-improvement-refactor-players-module branch March 20, 2023 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
improvement Improvements or additions to an existing feature
Projects
None yet
Milestone
v1.2.0
Development

Successfully merging this pull request may close these issues.

Improvement - Split "players" responsibility into players and stats
1 participant
@ArielleMurad