1.19 pets don't show defaultName

[andrewkm]

1.19 pets don't show defaultName
Frog: https://i.imgur.com/57dfNB2.png
Pig: https://i.imgur.com/xs2s1xk.png

Config: https://pastebin.com/94uD6QJx
What do?

[Arnuh]

Tested your config on a very old spigot version and latest paper but unable to reproduce, all 1.19 mobs have the (user)'s type name

[andrewkm]

Not sure what to say here, hmm.
We've fixed it as such: https://i.imgur.com/xvkmmkd.png
Perhaps @electronicboy could shed some light on the situation here.

[electronicboy]

Latest build from here https://jenkins.arnah.ca/job/EchoPet-Dev/

Reset all the config folder just to ensure nothing there, and cannot see the names; I've not had the time to rip stuff apart, but, generally looked like the entity data syncher was just not set, maybe something somewhere is clearing that data down the tree, but, the hackaround I had restored the name for me

[Arnuh]

Well my setup is completely clean. I'm interested in if #106 is the cause. As of 1.19 Allay, Axolotl, Frog, Goat, Tadpole, Villager, and Warden are implemented using that setup. Do these pets all have missing names? or only 1.19 ones

I don't really see a reason the name change has to be applied a tick later. I assumed the entity spawning process would be blocking still unless something has changed, if so then another method for applying data to the entity post spawn needs to be used.

[andrewkm]

As you mentioned, I can confirm that Allay, Axolotl, Frog, Goat, Tadpole, Villager, and Warden pet's do not display the name on a fully default version of the development branch. They do however display it correctly with our patch above.

Sorry for being this late to test and respond, being overseas makes it hard to meet my online commitments. <3
@Arnuh