Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.19 pets don't show defaultName #130

Closed
andrewkm opened this issue Jul 3, 2022 · 5 comments
Closed

1.19 pets don't show defaultName #130

andrewkm opened this issue Jul 3, 2022 · 5 comments
Labels

Comments

@andrewkm
Copy link
Contributor

andrewkm commented Jul 3, 2022

1.19 pets don't show defaultName
Frog: https://i.imgur.com/57dfNB2.png
Pig: https://i.imgur.com/xs2s1xk.png

Config: https://pastebin.com/94uD6QJx
What do?

@Arnuh
Copy link
Owner

Arnuh commented Jul 3, 2022

Tested your config on a very old spigot version and latest paper but unable to reproduce, all 1.19 mobs have the (user)'s type name

@andrewkm
Copy link
Contributor Author

andrewkm commented Jul 4, 2022

Not sure what to say here, hmm.
We've fixed it as such: https://i.imgur.com/xvkmmkd.png
Perhaps @electronicboy could shed some light on the situation here.

@electronicboy
Copy link

image
Latest build from here https://jenkins.arnah.ca/job/EchoPet-Dev/

Reset all the config folder just to ensure nothing there, and cannot see the names; I've not had the time to rip stuff apart, but, generally looked like the entity data syncher was just not set, maybe something somewhere is clearing that data down the tree, but, the hackaround I had restored the name for me

@Arnuh
Copy link
Owner

Arnuh commented Jul 4, 2022

Well my setup is completely clean. I'm interested in if #106 is the cause. As of 1.19 Allay, Axolotl, Frog, Goat, Tadpole, Villager, and Warden are implemented using that setup. Do these pets all have missing names? or only 1.19 ones

I don't really see a reason the name change has to be applied a tick later. I assumed the entity spawning process would be blocking still unless something has changed, if so then another method for applying data to the entity post spawn needs to be used.

@Arnuh Arnuh added the Bug label Jul 5, 2022
@andrewkm
Copy link
Contributor Author

andrewkm commented Jul 8, 2022

As you mentioned, I can confirm that Allay, Axolotl, Frog, Goat, Tadpole, Villager, and Warden pet's do not display the name on a fully default version of the development branch. They do however display it correctly with our patch above.

Sorry for being this late to test and respond, being overseas makes it hard to meet my online commitments. <3
@Arnuh

@andrewkm andrewkm closed this as completed Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants