Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "date" to the specification #35

Closed
PabloCanalSuarez opened this issue Mar 30, 2020 · 5 comments · Fixed by #21
Closed

Add "date" to the specification #35

PabloCanalSuarez opened this issue Mar 30, 2020 · 5 comments · Fixed by #21

Comments

@PabloCanalSuarez
Copy link
Contributor

I think we should also add a "date" as optional in the route specification. Right now, in the last update, the specification recognizes date in comments, but taking this field into the route itself could be useful to represent the date in which it was done.

The date should be included in the context with something like:

"date": {
      "@id": "schema:Date",
      "@type": "xsd:date"
},
@PabloCanalSuarez PabloCanalSuarez linked a pull request Mar 30, 2020 that will close this issue
@uo265363
Copy link

I agree with adding date in routes, and i also think dates should be stored in milliseconds to avoid confusing date formats like dd-mm-yyyy, mm-dd-yyyy, etc.

@UO264345
Copy link

@uo265363 the date data type has defined its format as "YYYY-MM-DD", so there should be no problem with that. What I would suggest is using xsd:dateTime instead, to have also hours, minutes and seconds recorded.

@PabloCanalSuarez
Copy link
Contributor Author

@uo265363 As our partner said, the format of the date shouln't be any problem as it's defined in a specific way.

@UO264345 The xsd:dateTime format is okay with me as I've seen routes of major platforms (like Strava) store their routes with this format of time, so it could be useful to change it. Following this, the result would be something like:

"date": {
      "@id": "schema:DateTime",
      "@type": "xsd:dateTime"
},

@uo265363
Copy link

In that case we also prefer having xsd:dateTime in order to have the seconds included.

@PabloCanalSuarez
Copy link
Contributor Author

Added to PR #21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants