Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

First try to fix route parsing crash #223

Merged
merged 23 commits into from
May 6, 2020
Merged

Conversation

fincamd
Copy link
Contributor

@fincamd fincamd commented Apr 30, 2020

No description provided.

@fincamd fincamd changed the base branch from master to development April 30, 2020 11:50
@codecov
Copy link

codecov bot commented Apr 30, 2020

Codecov Report

Merging #223 into development will increase coverage by 0.03%.
The diff coverage is 36.95%.

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #223      +/-   ##
===============================================
+ Coverage        35.82%   35.86%   +0.03%     
===============================================
  Files               40       40              
  Lines             1016     1040      +24     
  Branches            97      103       +6     
===============================================
+ Hits               364      373       +9     
- Misses             586      599      +13     
- Partials            66       68       +2     
Impacted Files Coverage Δ
src/components/podService/podPermissionHandler.js 8.10% <0.00%> (-0.47%) ⬇️
src/components/podService/podStoreHandler.js 4.44% <0.00%> (-0.05%) ⬇️
src/i18n.js 100.00% <ø> (ø)
src/pages/Groups.js 5.71% <0.00%> (-0.17%) ⬇️
src/pages/InfoView.js 56.52% <0.00%> (ø)
src/pages/RouteCreation.js 66.00% <ø> (ø)
src/pages/RouteHelp.js 100.00% <ø> (ø)
src/pages/RouteList.js 45.65% <0.00%> (-8.20%) ⬇️
src/pages/RouteSharedList.js 2.27% <0.00%> (ø)
src/pages/ShareView.js 0.00% <0.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a45d087...e267fa9. Read the comment docs.

@fincamd fincamd marked this pull request as ready for review May 1, 2020 12:09
@fincamd fincamd added the bugFix Something was fixed label May 1, 2020
@fincamd fincamd linked an issue May 1, 2020 that may be closed by this pull request
@fincamd fincamd merged commit d553bf1 into development May 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugFix Something was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Application crashes with routes not in expected format JSON-LD
5 participants