Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring of questions service #76

Closed
ChristianFN2 opened this issue Mar 16, 2024 · 2 comments · Fixed by #79
Closed

Refactoring of questions service #76

ChristianFN2 opened this issue Mar 16, 2024 · 2 comments · Fixed by #79
Assignees
Labels
Back End 🔌 Issues Regarding Back End Enhancement ✴️ New feature or request

Comments

@ChristianFN2
Copy link
Contributor

Currently the question service has only the functionallity for the flag questions and it is not extensible, so it should be refactored to be able to easily add more questions in the future.

@ChristianFN2 ChristianFN2 added Enhancement ✴️ New feature or request Back End 🔌 Issues Regarding Back End labels Mar 16, 2024
@ChristianFN2 ChristianFN2 self-assigned this Mar 16, 2024
@ChristianFN2
Copy link
Contributor Author

I think there is an inherent problem in how I constructed the query (if I want it to be generic), so I will reconstruct it and parametrize the method to accept several cathegories of image questions. For that I will use this official tutorial https://www.wikidata.org/wiki/Wikidata:SPARQL_tutorial, and this service to check the functioning of the queries and construct them easier https://query.wikidata.org/ (I had used it before and it is in the source links #4 ).

When I have designed the queries and the method, I expect the methodology of adding a new cathegory (for image questions) to be the following:

  1. We think in two related concepts that comply with the structure of the designed method.
  2. We use the query service to check if the result is the expected in quality and quantity
  3. We add a new endpoint to the service using the parametrized method (No need to create a new method)

@adriiglz
Copy link
Contributor

Refactored code for this service was made in #79 and now we have a good base for extending cathegories thanks to Christian

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Back End 🔌 Issues Regarding Back End Enhancement ✴️ New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants