From 2a700fdf1c7b4b245d0ebc7078248e3b5d5b1fd2 Mon Sep 17 00:00:00 2001 From: Diego Villanueva Date: Wed, 24 Apr 2024 23:11:48 +0200 Subject: [PATCH 1/2] Fix: Eliminated unnecessary code --- .../questions/question/QuestionHelper.java | 15 ++------------- 1 file changed, 2 insertions(+), 13 deletions(-) diff --git a/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java b/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java index 2cab945b..595f2529 100644 --- a/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java +++ b/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java @@ -12,20 +12,9 @@ @Component public class QuestionHelper { - private static int MAX_DISTRACTORS = 3; + private static final int MAX_DISTRACTORS = 3; public static List getDistractors(AnswerRepository answerRepository, Question question){ - List distractors = new ArrayList<>(); - AnswerCategory cat = question.getAnswerCategory(); - - switch (cat){ // Write the case only for the exceptions - case COUNTRY: - // Implement more cases - break; - default: - distractors = answerRepository.findDistractors(question.getAnswerCategory().toString(), question.getLanguage(), question.getCorrectAnswer().getText(), MAX_DISTRACTORS); - } - - return distractors; + return answerRepository.findDistractors(question.getAnswerCategory().toString(), question.getLanguage(), question.getCorrectAnswer().getText(), MAX_DISTRACTORS); } } From 2d222ad173d563ca39e90dd3188a8d2ab8345786 Mon Sep 17 00:00:00 2001 From: Diego Villanueva Date: Wed, 24 Apr 2024 23:16:38 +0200 Subject: [PATCH 2/2] Fix: Hide constructor --- .../lab/en2b/quizapi/questions/question/QuestionHelper.java | 2 ++ 1 file changed, 2 insertions(+) diff --git a/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java b/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java index 595f2529..f5c20c61 100644 --- a/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java +++ b/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionHelper.java @@ -12,6 +12,8 @@ @Component public class QuestionHelper { + private QuestionHelper(){} // To hide the implicit public constructor as this is static only + private static final int MAX_DISTRACTORS = 3; public static List getDistractors(AnswerRepository answerRepository, Question question){