fix: lang is not required

Arquisoft · Mar 11, 2024 · adacaa7 · adacaa7
1 parent 2ccc0b3
commit adacaa7
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 3 deletions.
diff --git a/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionController.java b/api/src/main/java/lab/en2b/quizapi/questions/question/QuestionController.java
@@ -9,8 +9,6 @@
 import org.springframework.http.ResponseEntity;
 import org.springframework.web.bind.annotation.*;
 
-import java.util.List;
-
 @RestController
 @RequestMapping("/questions")
 @RequiredArgsConstructor
@@ -23,7 +21,7 @@ private ResponseEntity<AnswerCheckResponseDto> answerQuestion(@PathVariable @Pos
     }
 
     @GetMapping("/new")
-    private ResponseEntity<QuestionResponseDto> generateQuestion(@RequestParam String lang){
+    private ResponseEntity<QuestionResponseDto> generateQuestion(@RequestParam(required = false) String lang){
         return ResponseEntity.ok(questionService.getRandomQuestion(lang));
     }
 

diff --git a/api/src/test/java/lab/en2b/quizapi/questions/QuestionControllerTest.java b/api/src/test/java/lab/en2b/quizapi/questions/QuestionControllerTest.java
@@ -51,6 +51,15 @@ void newQuestionShouldReturn200() throws Exception{
                 .andExpect(status().isOk());
     }
 
+    @Test
+    void newQuestionNoLangShouldReturn200() throws Exception{
+        mockMvc.perform(get("/questions/new")
+                        .with(user("test").roles("user"))
+                        .contentType("application/json")
+                        .with(csrf()))
+                .andExpect(status().isOk());
+    }
+
     @Test
     void questionByIdShouldReturn403() throws Exception{
         mockMvc.perform(get("/questions/1")